[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=345723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345723
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 00:43
Start Date: 19/Nov/19 00:43
Worklog Time Spent: 10m
Work Description: liumomo315 commented on issue #10145: [BEAM-8575] Add a
Python test to test windowing in DoFn finish_bundle()
URL: https://github.com/apache/beam/pull/10145#issuecomment-555277935
Thanks for the quick review!
>move the timestamp assignment to beam.Create()
This can be done, but does not make much difference, since we still want
both the process() and finish_bundle() to do something in this test, and see
the reason below.
>and combine the map function into the ParDo.
I think it's clearer to separate the Map from the test DoFn. The purpose of
this test is to verify that after a DoFn with finish_bundle() implemented, it
will produce results both from process() and finish_bundle(). More
specifically, it wants to make sure that when windowing is involved, the output
will be correct after the DoFn. The last Map is simply to print out all outputs
from the test DoFn. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 345723)
Time Spent: 10h 50m (was: 10h 40m)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 10h 50m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
