[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=346193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346193
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/19 19:17
Start Date: 19/Nov/19 19:17
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10070: [BEAM-8575]
Added a unit test for Reshuffle to test that Reshuffle pr…
URL: https://github.com/apache/beam/pull/10070#discussion_r348118164
##########
File path: sdks/python/apache_beam/transforms/util_test.py
##########
@@ -276,6 +279,13 @@ def process(self, element):
with self.assertRaisesRegex(ValueError, r'window.*None.*add_timestamps2'):
pipeline.run()
+class AddTimestamp(beam.DoFn):
+ def process(self, element, timestamp=beam.DoFn.TimestampParam):
+ yield beam.window.TimestampedValue(element, timestamp)
Review comment:
Yielding a TimestampedValue just sets the timestamp to that value.
Essentially, you're getting an element and its timestamp, and returning that
same element with its same timestamp. You then follow this with
FormatWithTimestamp gets the timestamp and actually does something with it. You
can just cut this function and set
`after_reshuffle = before_reshuffle | beam.Reshuffle()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 346193)
Time Spent: 12.5h (was: 12h 20m)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
