[ 
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=349197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349197
 ]

ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Nov/19 15:50
            Start Date: 25/Nov/19 15:50
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #9979: [BEAM-7951] Allow 
runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r350264092
 
 

 ##########
 File path: 
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/PaneInfo.java
 ##########
 @@ -40,7 +41,7 @@
  *
  * <p>Note: This does not uniquely identify a pane, and should not be used for 
comparisons.
  */
-public final class PaneInfo {
+public final class PaneInfo implements Serializable {
 
 Review comment:
   Not sure about this one. Why can't we use `PaneInfoCoder` instead?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 349197)
    Time Spent: 2h 40m  (was: 2.5h)

> Allow runner to configure customization WindowedValue coder such as 
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
>                 Key: BEAM-7951
>                 URL: https://issues.apache.org/jira/browse/BEAM-7951
>             Project: Beam
>          Issue Type: Sub-task
>          Components: java-fn-execution
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always 
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and 
> pane properties in Flink and so it will be better to make the coder 
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to