[
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=354006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-354006
]
ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/19 02:16
Start Date: 05/Dec/19 02:16
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on issue #9979: [BEAM-7951]
Allow runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#issuecomment-561935444
Hi @lukecwik @mxm
I have updated the PR. The changes as follows:
The previous Proto definition of windowing information has been removed.
Instead, I use the `Windowcoder` to encode the constant window information
and store it in the payload of the `ParamWindowedValueCoder`.
As for the coder name, I name it `ParamWindowedValueCoder` in the PR. We can
further discuss about it if you still have other concerns.
The last thing needs to be mentioned is it seems we have to make
`BoundedWindow` and `PaneInfo` implement Serializable, because the
coder(`ParamWindowedValueCoder`) needs to be serializable, So, I think the
members should also be serializable.
Best,
Jincheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 354006)
Time Spent: 3h 40m (was: 3.5h)
> Allow runner to configure customization WindowedValue coder such as
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-7951
> URL: https://issues.apache.org/jira/browse/BEAM-7951
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and
> pane properties in Flink and so it will be better to make the coder
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
