[
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=353487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353487
]
ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/19 14:24
Start Date: 04/Dec/19 14:24
Worklog Time Spent: 10m
Work Description: mwalenia commented on pull request #10267: [BEAM-6627]
Add size reporting to JdbcIOIT
URL: https://github.com/apache/beam/pull/10267#discussion_r353772041
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/DatabaseTestHelper.java
##########
@@ -79,6 +80,19 @@ public static String
getPostgresDBUrl(PostgresIOTestPipelineOptions options) {
options.getPostgresDatabaseName());
}
+ public static Long getPostgresTableSize(DataSource dataSource, String
tableName)
+ throws SQLException {
+ try (Connection connection = dataSource.getConnection()) {
+ try (Statement statement = connection.createStatement()) {
+ ResultSet resultSet =
+ statement.executeQuery(String.format("select
pg_relation_size('%s')", tableName));
+ if (resultSet.next()) {
+ return resultSet.getLong(1);
+ } else return 0L;
Review comment:
You're right, that's a huge improvement. Thanks for the suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 353487)
Time Spent: 16.5h (was: 16h 20m)
> Use Metrics API in IO performance tests
> ---------------------------------------
>
> Key: BEAM-6627
> URL: https://issues.apache.org/jira/browse/BEAM-6627
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Michal Walenia
> Assignee: Michal Walenia
> Priority: Minor
> Time Spent: 16.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
