[ 
https://issues.apache.org/jira/browse/BEAM-6627?focusedWorklogId=353488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353488
 ]

ASF GitHub Bot logged work on BEAM-6627:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Dec/19 14:24
            Start Date: 04/Dec/19 14:24
    Worklog Time Spent: 10m 
      Work Description: mwalenia commented on pull request #10267: [BEAM-6627] 
Add size reporting to JdbcIOIT
URL: https://github.com/apache/beam/pull/10267#discussion_r353772176
 
 

 ##########
 File path: 
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOIT.java
 ##########
 @@ -148,6 +150,18 @@ private void gatherAndPublishMetrics(PipelineResult 
writeResult, PipelineResult
           return NamedTestResult.create(
               uuid, timestamp, "write_time", (writeEnd - writeStart) / 1e3);
         });
+
+    suppliers.add(
+        ignore -> {
+          try {
+            Long tableSizeAfterWrite =
+                DatabaseTestHelper.getPostgresTableSize(dataSource, tableName);
+            return NamedTestResult.create(
+                uuid, timestamp, "total_size", tableSizeAfterWrite - 
tableSize);
+          } catch (SQLException e) {
 
 Review comment:
   You're right, I changed it
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 353488)
    Time Spent: 16h 40m  (was: 16.5h)

> Use Metrics API in IO performance tests
> ---------------------------------------
>
>                 Key: BEAM-6627
>                 URL: https://issues.apache.org/jira/browse/BEAM-6627
>             Project: Beam
>          Issue Type: Improvement
>          Components: testing
>            Reporter: Michal Walenia
>            Assignee: Michal Walenia
>            Priority: Minor
>          Time Spent: 16h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to