[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=355392&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355392
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 19:09
Start Date: 06/Dec/19 19:09
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #9953: [BEAM-8335]
Adds support for multi-output TestStream
URL: https://github.com/apache/beam/pull/9953#discussion_r354971976
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -163,45 +167,71 @@ class TestStream(PTransform):
"""Test stream that generates events on an unbounded PCollection of elements.
Each event emits elements, advances the watermark or advances the processing
- time. After all of the specified elements are emitted, ceases to produce
+ time. After all of the specified elements are emitted, ceases to produce
output.
"""
def __init__(self, coder=coders.FastPrimitivesCoder(), events=()):
super(TestStream, self).__init__()
assert coder is not None
self.coder = coder
- self.current_watermark = timestamp.MIN_TIMESTAMP
- self.events = list(events)
+ self.watermarks = {None: timestamp.MIN_TIMESTAMP}
+ self._events = list(events)
+ self.output_tags = set()
def get_windowing(self, unused_inputs):
return core.Windowing(window.GlobalWindows())
def expand(self, pbegin):
assert isinstance(pbegin, pvalue.PBegin)
self.pipeline = pbegin.pipeline
- return pvalue.PCollection(self.pipeline, is_bounded=False)
- def _infer_output_coder(self, input_type=None, input_coder=None):
- return self.coder
+ # This multiplexing the multiple output PCollections.
+ def mux(event):
+ if event.tag:
+ yield pvalue.TaggedOutput(event.tag, event)
+ else:
+ yield event
+ mux_output = (pbegin
Review comment:
Would it be possible for this expansion to be done on the runner side? That
way, TestStream remains mainly a marker with a list of events tagged for some
pcollections - and runners are free to expand them into their own particular
implementation? It seems like we could avoid having that whole implementation
here. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 355392)
Time Spent: 43h 20m (was: 43h 10m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 43h 20m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
