[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=358943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358943
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/19 21:23
Start Date: 12/Dec/19 21:23
Worklog Time Spent: 10m
Work Description: davidyan74 commented on pull request #10368:
[BEAM-8335] Modify PipelineInstrument to add TestStream for unbounded
PCollections
URL: https://github.com/apache/beam/pull/10368#discussion_r357377248
##########
File path:
sdks/python/apache_beam/runners/interactive/pipeline_instrument_test.py
##########
@@ -273,6 +281,47 @@ def visit_transform(self, transform_node):
p_origin.visit(v)
assert_pipeline_equal(self, p_origin, p_copy)
+ def test_instrument_example_unbounded_pipeline_to_read_cache(self):
+ p_origin, init_pcoll, second_pcoll = self._example_pipeline(watch=True,
+ bounded=False)
+ p_copy, _, _ = self._example_pipeline(watch=False, bounded=False)
+
+ # Mock as if cacheable PCollections are cached.
+ init_pcoll_cache_key = 'init_pcoll_' + str(
+ id(init_pcoll)) + '_' + str(id(init_pcoll.producer))
+ self._mock_write_cache(init_pcoll, init_pcoll_cache_key)
+ second_pcoll_cache_key = 'second_pcoll_' + str(
+ id(second_pcoll)) + '_' + str(id(second_pcoll.producer))
+ self._mock_write_cache(second_pcoll, second_pcoll_cache_key)
+ ie.current_env().cache_manager().exists = MagicMock(return_value=True)
+ instr.pin(p_copy)
Review comment:
Is it intentional that we ignore the return PipelineInstrument object?
Outside of the scope of this PR: Should we change the method name "pin"?
It's a confusing name. @KevinGG
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 358943)
Time Spent: 44h 20m (was: 44h 10m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 44h 20m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
