[
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=356916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-356916
]
ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/19 09:18
Start Date: 10/Dec/19 09:18
Worklog Time Spent: 10m
Work Description: sunjincheng121 commented on pull request #9979:
[BEAM-7951] Allow runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r355920632
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowedValue.java
##########
@@ -693,4 +697,110 @@ public void registerByteSizeObserver(WindowedValue<T>
value, ElementByteSizeObse
return Collections.singletonList(valueCoder);
}
}
+
+ /**
+ * A parameterized Coder for {@code WindowedValue}.
+ *
+ * <p>A {@code ParamWindowedValueCoder} only encodes and decodes the value.
It drops timestamp and
+ * windows for encoding, and uses defaults(constant) timestamp, and windows
for decoding.
+ */
+ public static class ParamWindowedValueCoder<T> extends
FullWindowedValueCoder<T> {
Review comment:
I was thinking `ParamWindowedValueCoder` is a special kind of
`FullWindowedValueCoder` with the parameterized timestamp, windows and pane
info for the WindowedValues, i.e., `ParamWindowedValueCoder` is an optimization
of `FullWindowedValueCoder`. We can also benefit from it such as reuse the code
of testing FullWindowedValueCoder in CommonCoderTest, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 356916)
Time Spent: 5h 40m (was: 5.5h)
> Allow runner to configure customization WindowedValue coder such as
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-7951
> URL: https://issues.apache.org/jira/browse/BEAM-7951
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and
> pane properties in Flink and so it will be better to make the coder
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
