[
https://issues.apache.org/jira/browse/BEAM-7951?focusedWorklogId=360964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-360964
]
ASF GitHub Bot logged work on BEAM-7951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/19 16:13
Start Date: 17/Dec/19 16:13
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #9979: [BEAM-7951] Allow
runner to configure customization WindowedValue coder.
URL: https://github.com/apache/beam/pull/9979#discussion_r358880441
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/WindowedValue.java
##########
@@ -500,11 +505,22 @@ private void ensureWindowsAreASet() {
return FullWindowedValueCoder.of(valueCoder, windowCoder);
}
- /** Returns the {@code ValueOnlyCoder} from the given valueCoder. */
+ /**
+ * Returns the {@code ValueOnlyCoder} from the given valueCoder.
+ *
+ * @deprecated Use {@link #getParamWindowedValueCoder(Coder)} instead. The
{@link
+ * ValueOnlyWindowedValueCoder} is deprecated now.
+ */
+ @Deprecated
public static <T> ValueOnlyWindowedValueCoder<T> getValueOnlyCoder(Coder<T>
valueCoder) {
Review comment:
I'm not sure we need to deprecate this method and replace all of the
invocations. This is still a useful method if no parameters are supplied. We
can simply redirect to the new ParamWindowedValueCoder here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 360964)
Time Spent: 7h (was: 6h 50m)
> Allow runner to configure customization WindowedValue coder such as
> ValueOnlyWindowedValueCoder
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-7951
> URL: https://issues.apache.org/jira/browse/BEAM-7951
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: sunjincheng
> Assignee: sunjincheng
> Priority: Major
> Time Spent: 7h
> Remaining Estimate: 0h
>
> The coder of WindowedValue cannot be configured and it’s always
> FullWindowedValueCoder. We don't need to serialize the timestamp, window and
> pane properties in Flink and so it will be better to make the coder
> configurable (i.e. allowing to use ValueOnlyWindowedValueCoder)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
