[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=361175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361175
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/19 22:45
Start Date: 17/Dec/19 22:45
Worklog Time Spent: 10m
Work Description: davidyan74 commented on pull request #10405:
[BEAM-8335] Background caching job
URL: https://github.com/apache/beam/pull/10405#discussion_r359069339
##########
File path: sdks/python/apache_beam/runners/interactive/interactive_runner.py
##########
@@ -125,6 +125,30 @@ def apply(self, transform, pvalueish, options):
def run_pipeline(self, pipeline, options):
pipeline_instrument = inst.pin(pipeline, options)
+ # The user_pipeline analyzed might be None if the pipeline given has
nothing
+ # to be cached and tracing back to the user defined pipeline is impossible.
+ # When it's None, there is no need to cache including the background
+ # caching job and no result to track since no background caching job is
+ # started at all.
+ user_pipeline = pipeline_instrument.user_pipeline
+
+ background_caching_job_result = ie.current_env().pipeline_result(
+ user_pipeline, is_main_job=False)
+ if (not background_caching_job_result or
Review comment:
Discussed offline. This block of code is a bit hard to read. Ning will do a
minor refactor to make this clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 361175)
Time Spent: 48h 50m (was: 48h 40m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 48h 50m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
