[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=361963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361963
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/19 23:53
Start Date: 20/Dec/19 23:53
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #10442: [BEAM-8335]
On Unbounded Source change
URL: https://github.com/apache/beam/pull/10442#discussion_r360610858
##########
File path:
sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -75,14 +77,16 @@ def is_background_caching_job_needed(user_pipeline):
return (has_source_to_cache(user_pipeline) and
# Checks if it's the first time running a job from the pipeline.
(not background_caching_job_result or
- # Or checks if there is no valid previous job.
+ # Or checks if there is no previous job.
background_caching_job_result.state not in (
# DONE means a previous job has completed successfully and the
# cached events are still valid.
runners.runner.PipelineState.DONE,
# RUNNING means a previous job has been started and is still
# running.
- runners.runner.PipelineState.RUNNING)))
+ runners.runner.PipelineState.RUNNING) or
+ # Or checks if we can invalidate the previous job.
+ is_unbounded_source_changed(user_pipeline)))
Review comment:
Yes, I agree. Changing it into `is_source_to_cache_changed`.
I was thinking about change in a bounded source wouldn't affect cached
unbounded sources. But it feels like that is going to split background caching
job into 2 categories or make the instrumenting process complicated (when we
add support to cache arbitrary source). Let's unify the source caching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 361963)
Time Spent: 50h 20m (was: 50h 10m)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 50h 20m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
