[
https://issues.apache.org/jira/browse/BEAM-9071?focusedWorklogId=368423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368423
]
ASF GitHub Bot logged work on BEAM-9071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/20 21:42
Start Date: 08/Jan/20 21:42
Worklog Time Spent: 10m
Work Description: udim commented on issue #10533: [BEAM-9071] Ignore
pytype before typing is fully developed.
URL: https://github.com/apache/beam/pull/10533#issuecomment-572270461
> Tests failed because encoding comments are required at the line1 and
line2: https://www.python.org/dev/peps/pep-0263/.
> Udi, will the skip type comment work after encoding comment?
Yes it should. I was thinking of putting it before the first import
statement in each file:
```
sed '0,/import/ s/.*import.*/# pytype: skip-file\n\n&/'
apache_beam/pvalue.py | less
```
or for all files:
```
find apache_beam | grep \\.py$ | xargs -n 1 sed '0,/import/ s/.*import.*/#
pytype: skip-file\n\n&/' | less
```
and when satisfied this will make changes to files:
```
find apache_beam | grep \\.py$ | xargs -n 1 sed -i '0,/import/
s/.*import.*/# pytype: skip-file\n\n&/'
```
https://stackoverflow.com/a/9453461/63302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 368423)
Time Spent: 0.5h (was: 20m)
> Ignore pytype untill the typing feature is fully developed
> ----------------------------------------------------------
>
> Key: BEAM-9071
> URL: https://issues.apache.org/jira/browse/BEAM-9071
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Boyuan Zhang
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Please remove all # pytype: skip-file after feature fully supported.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
