[
https://issues.apache.org/jira/browse/BEAM-9071?focusedWorklogId=368424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368424
]
ASF GitHub Bot logged work on BEAM-9071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/20 21:43
Start Date: 08/Jan/20 21:43
Worklog Time Spent: 10m
Work Description: udim commented on issue #10533: [BEAM-9071] Ignore
pytype before typing is fully developed.
URL: https://github.com/apache/beam/pull/10533#issuecomment-572270871
> > > LGTM.
> > >
> > > 1. Please wait for the tests to pass.
> > > 2. Please add a JIRA either on the same line or above to gradually
remove these and add this support.
> > >
> > > A question for @udim -- In the meantime do we need a system to ensure
new files have this comment in place?
> >
> >
> > There's a similar check you can adopt here:
> >
https://github.com/apache/beam/blob/4b772254447d1fa5fc7f0c5857312c70552ad7ef/sdks/python/scripts/run_pylint.sh#L108-L122
>
> Hey Udi, could you please help add the check after this PR checked in?
sure, np
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 368424)
Time Spent: 40m (was: 0.5h)
> Ignore pytype untill the typing feature is fully developed
> ----------------------------------------------------------
>
> Key: BEAM-9071
> URL: https://issues.apache.org/jira/browse/BEAM-9071
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Boyuan Zhang
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Please remove all # pytype: skip-file after feature fully supported.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)