[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=368745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368745
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 01:50
Start Date: 09/Jan/20 01:50
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364527420
##########
File path: sdks/python/apache_beam/portability/__init__.py
##########
@@ -17,3 +17,18 @@
"""For internal use only; no backwards-compatibility guarantees."""
from __future__ import absolute_import
+
+from typing import TYPE_CHECKING
+from typing import NamedTuple
+
+if TYPE_CHECKING:
+ from apache_beam.portability.api import metrics_pb2
+
+
+PropertiesFromEnumValue = NamedTuple(
Review comment:
yeah, I typically follow that convention as well. In this case,
common_urns.py would cause an import cycle, because it imports the _urn.py
files which need access to `PropertiesFromEnumValue`.
I considered putting `PropertiesFromEnumValue` in a new module, but it felt
like overkill. Happy to do so, if it's preferable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 368745)
Time Spent: 38.5h (was: 38h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 38.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
