[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=368767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368767
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 02:19
Start Date: 09/Jan/20 02:19
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10367: [BEAM-7746]
Add python type hints (part 2)
URL: https://github.com/apache/beam/pull/10367#discussion_r364532942
##########
File path: sdks/python/apache_beam/coders/coder_impl.py
##########
@@ -907,7 +907,8 @@ def encode_to_stream(self, value, out, nested):
buffer = create_OutputStream()
if (self._write_state is not None
and out.size() - start_size > self._write_state_threshold):
- tail = (value_iter[index + 1:] if isinstance(value, (list, tuple))
+ tail = (value_iter[index + 1:]
+ if isinstance(value_iter, (list, tuple))
Review comment:
It protects against this error:
```
apache_beam/coders/coder_impl.py:910: error: Value of type
"Union[Iterator[Any], List[Any], Tuple[Any, ...]]" is not indexable [index]
```
The code is using the type of `value` to implicitly determine the type of
`value_iter`. This confuses humans and linters :) By using `value_iter` mypy
knows to reduce `Union[Iterator[Any], List[Any], Tuple[Any, ...]]` down to
`Union[List[Any], Tuple[Any, ...]]` before the `__getitem__` code is checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 368767)
Time Spent: 39.5h (was: 39h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 39.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
