[
https://issues.apache.org/jira/browse/BEAM-6008?focusedWorklogId=370918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-370918
]
ASF GitHub Bot logged work on BEAM-6008:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/20 17:27
Start Date: 13/Jan/20 17:27
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #10566: [BEAM-6008]
Propagate errors during pipeline execution in Java's PortableRunner
URL: https://github.com/apache/beam/pull/10566#discussion_r365928740
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/JobInvocation.java
##########
@@ -243,6 +249,7 @@ private synchronized void setState(JobState.Enum state) {
}
private synchronized void sendMessage(JobMessage message) {
+ messageHistory.add(message);
Review comment:
I've added this to make it consistent with the state updates, which we also
save. However, this may be too memory intense, I'm seeing that the test time
increased here:
https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Commit/2320/
Need to check if this is due to this change. If so, we could subscribe to
the messages before running the pipeline which would remove the need to save
the messages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 370918)
Time Spent: 3h 10m (was: 3h)
> Propagate errors through portable runner
> ----------------------------------------
>
> Key: BEAM-6008
> URL: https://issues.apache.org/jira/browse/BEAM-6008
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
