[
https://issues.apache.org/jira/browse/BEAM-6008?focusedWorklogId=371091&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371091
]
ASF GitHub Bot logged work on BEAM-6008:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/20 20:59
Start Date: 13/Jan/20 20:59
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10566: [BEAM-6008]
Propagate errors during pipeline execution in Java's PortableRunner
URL: https://github.com/apache/beam/pull/10566#discussion_r366024932
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/jobsubmission/JobInvocation.java
##########
@@ -243,6 +249,7 @@ private synchronized void setState(JobState.Enum state) {
}
private synchronized void sendMessage(JobMessage message) {
+ messageHistory.add(message);
Review comment:
yeah, I'd be wary of storing all of that. There should be a way to cap the
number of historical messages a user cares about. We could choose a sensible
default for now and come back and expose it as an option later if anyone cares
to do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 371091)
Time Spent: 4.5h (was: 4h 20m)
> Propagate errors through portable runner
> ----------------------------------------
>
> Key: BEAM-6008
> URL: https://issues.apache.org/jira/browse/BEAM-6008
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
