[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=374621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-374621
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jan/20 15:32
Start Date: 20/Jan/20 15:32
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #10563: [BEAM-7310]
Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#discussion_r368604901
##########
File path:
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOTest.java
##########
@@ -160,14 +169,36 @@
private static final String TIMESTAMP_START_MILLIS_CONFIG =
"test.timestamp.start.millis";
private static final String TIMESTAMP_TYPE_CONFIG = "test.timestamp.type";
+ private static Serializer<AvroGeneratedUser> getSerializer(boolean isKey) {
+ SchemaRegistryClient registryClient = new MockSchemaRegistryClient();
+ Map<String, Object> map = new HashMap<>();
+ map.put(KafkaAvroDeserializerConfig.AUTO_REGISTER_SCHEMAS, true);
+ map.put(KafkaAvroDeserializerConfig.SCHEMA_REGISTRY_URL_CONFIG,
"mock://my-scope-name");
+ Serializer<AvroGeneratedUser> serializer = (Serializer) new
KafkaAvroSerializer(registryClient);
+ serializer.configure(map, isKey);
+ return serializer;
+ }
+
+ private static Deserializer<AvroGeneratedUser> getDeserializer(
+ boolean key, SchemaRegistryClient registryClient) {
+ Map<String, Object> map = new HashMap<>();
+ map.put(KafkaAvroDeserializerConfig.SPECIFIC_AVRO_READER_CONFIG, "true");
+ map.put(KafkaAvroDeserializerConfig.SCHEMA_REGISTRY_URL_CONFIG,
"mock://my-scope-name");
+ Deserializer<AvroGeneratedUser> deserializer =
+ (Deserializer) new KafkaAvroDeserializer(registryClient);
+ deserializer.configure(map, key);
+ return deserializer;
+ }
+
// Update mock consumer with records distributed among the given topics,
each with given number
// of partitions. Records are assigned in round-robin order among the
partitions.
private static MockConsumer<byte[], byte[]> mkMockConsumer(
List<String> topics,
int partitionsPerTopic,
int numElements,
OffsetResetStrategy offsetResetStrategy,
- Map<String, Object> config) {
+ Map<String, Object> config,
+ boolean isAvro) {
Review comment:
maybe rename `useAvro` is a more clear name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 374621)
Time Spent: 3h 20m (was: 3h 10m)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
