[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=375059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375059
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/20 16:41
Start Date: 21/Jan/20 16:41
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #10563:
[BEAM-7310] Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#discussion_r369114028
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -817,6 +892,27 @@ public void setValueDeserializer(String
valueDeserializer) {
return new TypedWithoutMetadata<>(this);
}
+ private Schema fetchAvroSchema(String schemaRegistryUrl, String subject) {
+ SchemaRegistryClient registryClient;
+ if (getSchemaRegistryClientFactoryFn() != null) {
+ registryClient =
getSchemaRegistryClientFactoryFn().apply(schemaRegistryUrl);
+ } else {
+ registryClient = new CachedSchemaRegistryClient(schemaRegistryUrl,
Integer.MAX_VALUE);
+ }
+
+ SchemaMetadata latestSchemaMetadata;
+ try {
+ latestSchemaMetadata = registryClient.getLatestSchemaMetadata(subject);
+ } catch (IOException | RestClientException e) {
+ throw new IllegalArgumentException(
+ "Unable to get latest schema metadata for subject: " + subject, e);
+ }
+
+ final Schema avroSchema = new
Schema.Parser().parse(latestSchemaMetadata.getSchema());
+ checkArgument(avroSchema != null, "Avro schema can't be null");
Review comment:
I guess it's almost impossible but I'd prefer to leave this check "just in
case" since we can't be sure on 100% and I don't see any disadvantages to have
it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375059)
Time Spent: 3h 50m (was: 3h 40m)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
