[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=374799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-374799
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/20 04:12
Start Date: 21/Jan/20 04:12
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #10594: [BEAM-7746] Stop
automatically creating staticmethods in register_urn
URL: https://github.com/apache/beam/pull/10594#issuecomment-576510338
Looks like the code changed a bit since I originally wrote this change.
Will fix these and look for anything else I may have missed.
On Fri, Jan 17, 2020 at 4:15 PM Udi Meiri <[email protected]> wrote:
> *@udim* commented on this pull request.
> ------------------------------
>
> In sdks/python/apache_beam/coders/coders.py
> <https://github.com/apache/beam/pull/10594#discussion_r368185763>:
>
> > @@ -1014,6 +1015,7 @@ def to_runner_api_parameter(self, context):
> else:
> return super(TupleCoder, self).to_runner_api_parameter(context)
>
> + @staticmethod
> @Coder.register_urn(common_urns.coders.KV.urn, None)
> def from_runner_api_parameter(unused_payload, components,
unused_context):
> return TupleCoder(components)
>
> Should ParamWindowedValueCoder.from_runner_api_parameter also get the
> @staticmethod decorator?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/beam/pull/10594?email_source=notifications&email_token=AAAPOE7G3EPNSYCU3G74NFLQ6JCZZA5CNFSM4KG3SOZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSHM7UA#pullrequestreview-344903632>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAAPOE5XHZV7BVYNWGTKP2TQ6JCZZANCNFSM4KG3SOZA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 374799)
Time Spent: 54h (was: 53h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 54h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
