[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=377131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377131
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/20 02:11
Start Date: 25/Jan/20 02:11
Worklog Time Spent: 10m
Work Description: udim commented on pull request #10592: [BEAM-7746]
Introduce a protocol to handle various types of partitioning buffers
URL: https://github.com/apache/beam/pull/10592#discussion_r370905318
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1026,12 +1050,23 @@ def _extract_endpoints(stage, # type:
fn_api_runner_transforms.Stage
class StateServicer(beam_fn_api_pb2_grpc.BeamFnStateServicer,
sdk_worker.StateHandler):
+ class CopyOnWriteListProtocol(Protocol):
Review comment:
This protocol's name does not match its structure. Structurally, _ListBuffer
is a CopyOnWriteListProtocol but semantically it does not do the CopyOnWrite
part. A verb other than `append` could be used to make the distinction, perhaps
`overlay`? (and the protocol could be OverlayList or FloatingList)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 377131)
Time Spent: 55h 20m (was: 55h 10m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 55h 20m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
