[
https://issues.apache.org/jira/browse/BEAM-9120?focusedWorklogId=375110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375110
]
ASF GitHub Bot logged work on BEAM-9120:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/20 17:59
Start Date: 21/Jan/20 17:59
Worklog Time Spent: 10m
Work Description: markflyhigh commented on pull request #10589: [WIP]
[BEAM-9120] Deprecate onSuccessMatcher, onCreateMatcher
URL: https://github.com/apache/beam/pull/10589#discussion_r369154925
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/TestDataflowRunner.java
##########
@@ -102,8 +101,6 @@ DataflowPipelineJob run(Pipeline pipeline, DataflowRunner
runner) {
job.getJobId(),
expectedNumberOfAssertions);
- assertThat(job, testPipelineOptions.getOnCreateMatcher());
Review comment:
This makes sure test fail-fast if pipeline creation failed. Do we have
alternative solutions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375110)
Time Spent: 1.5h (was: 1h 20m)
> Deprecate onSuccessMatcher, onCreateMatcher
> -------------------------------------------
>
> Key: BEAM-9120
> URL: https://issues.apache.org/jira/browse/BEAM-9120
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Instead of creating matchers on PipelineResult we should just make assertions
> on real matchers after waiting for the pipeline to finish.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
