[
https://issues.apache.org/jira/browse/BEAM-9213?focusedWorklogId=379151&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379151
]
ASF GitHub Bot logged work on BEAM-9213:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/20 05:00
Start Date: 30/Jan/20 05:00
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10708: [BEAM-9213]
throw error when flink_submit_uber_jar and not flink_master
URL: https://github.com/apache/beam/pull/10708#discussion_r372760207
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner.py
##########
@@ -51,8 +51,11 @@ def default_job_server(self, options):
flink_master = self.add_http_scheme(
flink_options.flink_master)
flink_options.flink_master = flink_master
- if (flink_options.flink_submit_uber_jar
- and flink_master not in MAGIC_HOST_NAMES):
+ if flink_options.flink_submit_uber_jar:
+ if flink_master in MAGIC_HOST_NAMES:
+ raise ValueError(
+ 'Cannot use flink_submit_uber_jar with flink_master %s'
+ % flink_master)
Review comment:
> I think we may want to make flink_submit_uber_jar the default
In the long term, I think we should make flink_submit_uber_jar the _only_
option in FlinkRunner. Having two substantially different behaviors under the
same "runner" is confusing to users, and in retrospect
"flink_submit_uber_jar=false" kind of seems like only an intermediate step.
WDYT?
(Incidentally, I've realized all this terminology itself is confusing. "Uber
jar" seems to imply java, even though that is the "java-less" option.)
However, in the short term, I'm not yet confident that flink_submit_uber_jar
is ready. I've been seeing issues with it hanging in Beam 2.18:
[BEAM-9225](https://issues.apache.org/jira/browse/BEAM-9225)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379151)
Time Spent: 50m (was: 40m)
> FlinkRunner ignores --flink_submit_uber_jar when master unset
> -------------------------------------------------------------
>
> Key: BEAM-9213
> URL: https://issues.apache.org/jira/browse/BEAM-9213
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Minor
> Labels: portability-flink
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Instead, an error should be thrown to let the user know that
> flink_submit_uber_jar is incompatible with auto/local master.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
