[ 
https://issues.apache.org/jira/browse/BEAM-9213?focusedWorklogId=387351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387351
 ]

ASF GitHub Bot logged work on BEAM-9213:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Feb/20 13:33
            Start Date: 14/Feb/20 13:33
    Worklog Time Spent: 10m 
      Work Description: mxm commented on pull request #10708: [BEAM-9213] throw 
error when flink_submit_uber_jar and not flink_master
URL: https://github.com/apache/beam/pull/10708#discussion_r379431228
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/flink_runner.py
 ##########
 @@ -51,8 +51,11 @@ def default_job_server(self, options):
     flink_master = self.add_http_scheme(
         flink_options.flink_master)
     flink_options.flink_master = flink_master
-    if (flink_options.flink_submit_uber_jar
-        and flink_master not in MAGIC_HOST_NAMES):
+    if flink_options.flink_submit_uber_jar:
+      if flink_master in MAGIC_HOST_NAMES:
+        raise ValueError(
+            'Cannot use flink_submit_uber_jar with flink_master %s'
+            % flink_master)
 
 Review comment:
   How about a `--force-mode` parameter which would enforce a specific mode, 
e.g. `--force-mode uberjar` to user the uber jar mode. It seems appropriate 
then to throw an error in case that mode cannot be run. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 387351)
    Time Spent: 2h  (was: 1h 50m)

> FlinkRunner ignores --flink_submit_uber_jar when master unset
> -------------------------------------------------------------
>
>                 Key: BEAM-9213
>                 URL: https://issues.apache.org/jira/browse/BEAM-9213
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-flink
>            Reporter: Kyle Weaver
>            Assignee: Kyle Weaver
>            Priority: Minor
>              Labels: portability-flink
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Instead, an error should be thrown to let the user know that 
> flink_submit_uber_jar is incompatible with auto/local master.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to