[
https://issues.apache.org/jira/browse/BEAM-8280?focusedWorklogId=380194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380194
]
ASF GitHub Bot logged work on BEAM-8280:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/20 20:16
Start Date: 31/Jan/20 20:16
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10735:
[BEAM-8280][BEAM-8629] Make IOTypeHints immutable
URL: https://github.com/apache/beam/pull/10735#discussion_r373667044
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -305,7 +326,7 @@ def has_simple_output_type(self):
return (self.output_types and len(self.output_types[0]) == 1 and
not self.output_types[1])
- def strip_iterable(self):
+ def strip_iterable(self): # type: (...) -> IOTypeHints
Review comment:
Type comment should go after the function. No need for `...` unless you are
skipping the definition of an argument (the type of `self` is implicit).
```suggestion
def strip_iterable(self):
# type: () -> IOTypeHints
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 380194)
Time Spent: 1h 20m (was: 1h 10m)
> re-enable IOTypeHints.from_callable
> -----------------------------------
>
> Key: BEAM-8280
> URL: https://issues.apache.org/jira/browse/BEAM-8280
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> See https://issues.apache.org/jira/browse/BEAM-8279
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
