[
https://issues.apache.org/jira/browse/BEAM-8280?focusedWorklogId=381132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381132
]
ASF GitHub Bot logged work on BEAM-8280:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/20 18:38
Start Date: 03/Feb/20 18:38
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #10735:
[BEAM-8280][BEAM-8629] Make IOTypeHints immutable
URL: https://github.com/apache/beam/pull/10735#discussion_r374270274
##########
File path: sdks/python/apache_beam/typehints/decorators.py
##########
@@ -217,7 +220,10 @@ def get_signature(func):
return signature
-class IOTypeHints(object):
+class IOTypeHints(NamedTuple('IOTypeHints', [
+ ('input_types', Optional[Tuple[Tuple[Any, ...], Dict[str, Any]]]),
+ ('output_types', Optional[Tuple[Tuple[Any, ...], Dict[str, Any]]]),
+ ('origin', List[str])])):
Review comment:
Something like this:
```python
def __repr__(self):
repr_fmt = '{typename}({repr_fmt})'.format(
typename=type(self).__name__,
repr_fmt=', '.join('{name}=%r'.format(name=name) for name in
self._fields)
)
return repr_fmt % self
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 381132)
Time Spent: 2h 50m (was: 2h 40m)
> re-enable IOTypeHints.from_callable
> -----------------------------------
>
> Key: BEAM-8280
> URL: https://issues.apache.org/jira/browse/BEAM-8280
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> See https://issues.apache.org/jira/browse/BEAM-8279
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
