[
https://issues.apache.org/jira/browse/BEAM-5605?focusedWorklogId=380251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380251
]
ASF GitHub Bot logged work on BEAM-5605:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/20 23:00
Start Date: 31/Jan/20 23:00
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10702: [BEAM-5605]
Migrate splittable DoFn methods to use "new" DoFn style argument providing.
URL: https://github.com/apache/beam/pull/10702#discussion_r373722630
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##########
@@ -871,13 +960,20 @@ public Duration getAllowedTimestampSkew() {
* Annotation for the method that creates a new {@link RestrictionTracker}
for the restriction of
* a <a href="https://s.apache.org/splittable-do-fn";>splittable</a> {@link
DoFn}.
*
- * <p>Signature: {@code MyRestrictionTracker newTracker(RestrictionT
restriction, <optional
- * arguments>);} where {@code MyRestrictionTracker} must be a subtype of
{@code
- * RestrictionTracker<RestrictionT>}.
+ * <p>Signature: {@code MyRestrictionTracker newTracker(<optional
arguments>);}
*
- * <p>The optional arguments are allowed to be:
+ * <p>This method must satisfy the following constraints:
*
* <ul>
+ * <li>The return type must be a subtype of {@code
RestrictionTracker<RestrictionT, PositionT>}.
+ * It is suggested to use as narrow of a return type definition as
possible (for example
+ * prefer to use a square type over a shape type as a square is a type
of a shape).
+ * <li>If one of its arguments is tagged with the {@link Element}
annotation, then it will be
Review comment:
No.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 380251)
Time Spent: 11.5h (was: 11h 20m)
> Support Portable SplittableDoFn for batch
> -----------------------------------------
>
> Key: BEAM-5605
> URL: https://issues.apache.org/jira/browse/BEAM-5605
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Roll-up item tracking work towards supporting portable SplittableDoFn for
> batch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
