[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=380952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380952
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/20 13:53
Start Date: 03/Feb/20 13:53
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #10563: [BEAM-7310]
Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#discussion_r374093419
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/BasicCSRClientProvider.java
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.kafka;
+
+import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient;
+import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient;
+import javax.annotation.Nullable;
+
+/** Basic implementation of {@link CSRClientProvider} used by default in
{@link KafkaIO}. */
+public class BasicCSRClientProvider implements CSRClientProvider {
+ @Nullable private final String keySchemaSubject;
+ @Nullable private final String valueSchemaSubject;
+ private final String schemaRegistryUrl;
+
+ public BasicCSRClientProvider(
+ String schemaRegistryUrl, String keySchemaSubject, String
valueSchemaSubject) {
+ this.schemaRegistryUrl = schemaRegistryUrl;
+ this.keySchemaSubject = keySchemaSubject;
+ this.valueSchemaSubject = valueSchemaSubject;
+ }
+
+ @Override
+ public String getSchemaRegistryUrl() {
Review comment:
Remove, see comment on the interface below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 380952)
Time Spent: 10h 40m (was: 10.5h)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
