[
https://issues.apache.org/jira/browse/BEAM-7310?focusedWorklogId=376884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-376884
]
ASF GitHub Bot logged work on BEAM-7310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/20 15:59
Start Date: 24/Jan/20 15:59
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #10563:
[BEAM-7310] Add support of Confluent Schema Registry for KafkaIO
URL: https://github.com/apache/beam/pull/10563#discussion_r370708532
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##########
@@ -586,6 +636,55 @@ public void setValueDeserializer(String
valueDeserializer) {
return
toBuilder().setValueDeserializer(valueDeserializer).setValueCoder(valueCoder).build();
}
+ /**
+ * Sets a Confluent Schema Registry URL in case of using Avro schema
serialised key/values. It
+ * should be used together with {@link #withKeySchemaSubject(String)}
and/or {@link
+ * #withValueSchemaSubject(String)}.
+ */
+ public Read<K, V> withSchemaRegistry(String schemaRegistryUrl) {
+ return withConsumerConfigUpdates(
+ ImmutableMap.of(
+ KafkaAvroDeserializerConfig.SCHEMA_REGISTRY_URL_CONFIG,
schemaRegistryUrl));
+ }
+
+ /**
+ * Sets a subject name to obtain Avro schema from Confluent Schema
Registry used for key
+ * serialisation. Also, sets {@link KafkaAvroDeserializer} as a key
deserializer. {@link Coder}
+ * will be inferred based on obtained Avro schema by {@link AvroCoder}. It
should be used along
+ * with {@link #withSchemaRegistry(String)}.
+ */
Review comment:
Please, see my comment above. I'm open for discussion on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 376884)
Time Spent: 9.5h (was: 9h 20m)
> Confluent Schema Registry support in KafkaIO
> --------------------------------------------
>
> Key: BEAM-7310
> URL: https://issues.apache.org/jira/browse/BEAM-7310
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Affects Versions: 2.12.0
> Reporter: Yohei Shimomae
> Assignee: Alexey Romanenko
> Priority: Minor
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Confluent Schema Registry is useful when we manage Avro Schema but KafkaIO
> does not support Confluent Schema Registry as discussed here.
> https://stackoverflow.com/questions/56035121/unable-to-connect-from-dataflow-job-to-schema-registry-when-schema-registry-requ
> https://lists.apache.org/thread.html/7695fccddebd08733b80ae1e43b79b636b63cd5fe583a2bdeecda6c4@%3Cuser.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
