[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=383132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383132
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/20 20:27
Start Date: 06/Feb/20 20:27
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #10784: [BEAM-7746]
DoFnRunner.receive() does not return a value
URL: https://github.com/apache/beam/pull/10784#issuecomment-583095068
> The bug here is that DoFnRunner.receive should return
self.process(windowed_value).
That would make `DoFnRunner` the only `Receiver` that returns a value from
`receive`, which would force us to change the return type on `Receiver.receive`
to `Any`, which would weaken the typing overall and maybe cause other issues.
For reference, here's `Receiver`:
```python
class Receiver(object):
def receive(self, windowed_value):
# type: (WindowedValue) -> None
raise NotImplementedError
```
> Alternatively assert that the return value of
self.do_fn_invoker.invoke_process(windowed_value) is None. and don't return it.
Like this?
```python
class DoFnRunner(Receiver):
...
def process(self, windowed_value):
# type: (WindowedValue) -> None
try:
result = self.do_fn_invoker.invoke_process(windowed_value)
assert result is None
except BaseException as exn:
self._reraise_augmented(exn)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 383132)
Time Spent: 61.5h (was: 61h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 61.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
