[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=379623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379623
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/20 21:45
Start Date: 30/Jan/20 21:45
Worklog Time Spent: 10m
Work Description: chadrik commented on issue #10593: [BEAM-7746] Add
typing for try_split
URL: https://github.com/apache/beam/pull/10593#issuecomment-580475184
I've been meaning to check in on this. @robertwb had some concerns:
> Talking to @boyuanzz this code is actively being developed, so it might
make sense to hold off a bit. In particular, the splits are not entirely
symmetric (e.g. a primary only ever has the WindowedValue, while the Residual
is more properly a Tuple[WindowedValue, Optiona[Timestamp],
Optional[Timestamp]].
@boyuanzz I'd love to get this merged and have you incorporate typing into
your changes, but it may take a bit of effort on your part to properly annotate
your changes, depending on how familiar you are with mypy and typing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379623)
Time Spent: 59h 50m (was: 59h 40m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 59h 50m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
