[
https://issues.apache.org/jira/browse/BEAM-9229?focusedWorklogId=387692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387692
]
ASF GitHub Bot logged work on BEAM-9229:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/20 21:30
Start Date: 14/Feb/20 21:30
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #10733: [BEAM-9229]
Adding dependency information to Environment proto
URL: https://github.com/apache/beam/pull/10733#discussion_r379652739
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1093,6 +1093,66 @@ message SideInput {
FunctionSpec window_mapping_fn = 3;
}
+message StandardArtifacts {
+ enum Types {
+ // A URN for artifacts described by URLs.
+ // payload: ArtifactUrlPayload
+ URL = 0 [(beam_urn) = "beam:artifact:url:v1"];
+
+ // A URN for artifacts embedded in ArtifactInformation proto.
+ // payload: EmbeddedFilePayload.
+ EMBEDDED = 1 [(beam_urn) = "beam:artifact:embedded:v1"];
+
+ // A URN for Python artifacts hosted on PYPI.
+ // payload: PypiPayload
+ PYPI = 2 [(beam_urn) = "beam:artifact:pypi:v1"];
+
+ // A URN for Java artifacts hosted on a Maven repository.
+ // payload: MavenPayload
+ MAVEN = 3 [(beam_urn) = "beam:artifact:maven:v1"];
+ }
+}
+
+message ArtifactUrlPayload {
+ // a string for an artifact URL e.g. "https://.../foo.jar"; or
"file:///tmp/foo.jar"
+ string path = 1;
+}
+
+message EmbeddedFilePayload {
+ // raw data bytes for an embedded artifact
+ bytes data = 1;
+
+ // A name of the embedded file.
+ string name = 2;
+}
+
+message PyPIPayload {
+ // Pypi compatible artifact id e.g. "apache-beam"
+ string artifact_id = 1;
+
+ // Pypi compatible version string.
+ string version = 2;
+}
+
+message MavenPayload {
+ // A string specifying Maven artifact.
+ // The standard format is
"groupId:artifactId:version[:packaging[:classifier]]"
+ string artifact_specifier = 1;
Review comment:
Yes.
See:
https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm#MAVEN402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 387692)
Time Spent: 6.5h (was: 6h 20m)
> Adding dependency information to Environment proto
> --------------------------------------------------
>
> Key: BEAM-9229
> URL: https://issues.apache.org/jira/browse/BEAM-9229
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> Adding dependency information to Environment proto.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
