[
https://issues.apache.org/jira/browse/BEAM-9229?focusedWorklogId=389683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389683
]
ASF GitHub Bot logged work on BEAM-9229:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/20 23:52
Start Date: 19/Feb/20 23:52
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10733: [BEAM-9229]
Adding dependency information to Environment proto
URL: https://github.com/apache/beam/pull/10733#discussion_r381614435
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1158,6 +1158,90 @@ message SideInput {
FunctionSpec window_mapping_fn = 3;
}
+message StandardArtifacts {
+ enum Types {
+ // A URN for locally-accessible artifact files.
+ // payload: ArtifactFilePayload
+ FILE = 0 [(beam_urn) = "beam:artifact:type:file:v1"];
+
+ // A URN for artifacts described by URLs.
+ // payload: ArtifactUrlPayload
+ URL = 1 [(beam_urn) = "beam:artifact:type:url:v1"];
+
+ // A URN for artifacts embedded in ArtifactInformation proto.
+ // payload: EmbeddedFilePayload.
+ EMBEDDED = 2 [(beam_urn) = "beam:artifact:type:embedded:v1"];
+
+ // A URN for Python artifacts hosted on PYPI.
+ // payload: PypiPayload
+ PYPI = 3 [(beam_urn) = "beam:artifact:type:pypi:v1"];
+
+ // A URN for Java artifacts hosted on a Maven repository.
+ // payload: MavenPayload
+ MAVEN = 4 [(beam_urn) = "beam:artifact:type:maven:v1"];
+ }
+ enum Roles {
+ // A URN for staging-to role.
+ // payload: ArtifactStagingToRolePayload
+ STAGING_TO = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+ }
+}
+
+message ArtifactFilePayload {
+ // a string for an artifact path e.g. "/tmp/foo.jar"
+ string path = 1;
+
+ // The hex-encoded sha256 checksum of the artifact.
+ string sha256 = 2;
+}
+
+message ArtifactUrlPayload {
+ // a string for an artifact URL e.g. "https://.../foo.jar"; or
"gs://tmp/foo.jar"
+ string path = 1;
+}
+
+message EmbeddedFilePayload {
+ // raw data bytes for an embedded artifact
+ bytes data = 1;
Review comment:
We could consider just letting the payload be the raw bytes (and similarly
for other one-field payloads).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389683)
Time Spent: 7h (was: 6h 50m)
> Adding dependency information to Environment proto
> --------------------------------------------------
>
> Key: BEAM-9229
> URL: https://issues.apache.org/jira/browse/BEAM-9229
> Project: Beam
> Issue Type: Sub-task
> Components: beam-model
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Adding dependency information to Environment proto.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
