[
https://issues.apache.org/jira/browse/BEAM-9326?focusedWorklogId=389544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389544
]
ASF GitHub Bot logged work on BEAM-9326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/20 18:17
Start Date: 19/Feb/20 18:17
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #10879:
[BEAM-9326] Make JsonToRow transform input <String> instead of <? extends
String>
URL: https://github.com/apache/beam/pull/10879#discussion_r381455388
##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java
##########
@@ -225,7 +225,7 @@ public void testPipelineSDKExceptionHandling() {
@Test
@Category(ValidatesRunner.class)
public void testMultipleApply() {
- PTransform<PCollection<? extends String>, PCollection<String>> myTransform
= addSuffix("+");
+ MapElements<String, String> myTransform = addSuffix("+");
Review comment:
Suggest changing `? extends String` to just `String` but otherwise leaving
the type as `PTransform`. This is a good way to indicate that you don't intend
to use any other facts about the transform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 389544)
Time Spent: 20m (was: 10m)
> JsonToRow transform should not use bounded Wildcards for its input
> ------------------------------------------------------------------
>
> Key: BEAM-9326
> URL: https://issues.apache.org/jira/browse/BEAM-9326
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.20.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The JsonToRow PTransform input is a String (a final class in Java) so no
> reason
> to define a bounded wildcard as its argument.
> We should use <? extends String> in Beam's codebase only when required by Java
> Generics constraints.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
