[
https://issues.apache.org/jira/browse/BEAM-8335?focusedWorklogId=389583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389583
]
ASF GitHub Bot logged work on BEAM-8335:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Feb/20 19:50
Start Date: 19/Feb/20 19:50
Worklog Time Spent: 10m
Work Description: davidyan74 commented on pull request #10892:
[BEAM-8335] Make TestStream to/from runner_api include the output_tags property.
URL: https://github.com/apache/beam/pull/10892#discussion_r381502828
##########
File path: sdks/python/apache_beam/testing/test_stream.py
##########
@@ -188,7 +198,16 @@ def _infer_output_coder(self, input_type=None,
input_coder=None):
def expand(self, pbegin):
assert isinstance(pbegin, pvalue.PBegin)
self.pipeline = pbegin.pipeline
- return pvalue.PCollection(self.pipeline, is_bounded=False)
+ if len(self.output_tags) == 0:
+ self.output_tags = set([None])
+
+ if len(self.output_tags) == 1:
Review comment:
Is there a reason why we treat the case with only one output_tag as a
special case (i.e. not returning a dict) ? Please add the reason as a comment
in this code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 389583)
Time Spent: 60h 40m (was: 60.5h)
> Add streaming support to Interactive Beam
> -----------------------------------------
>
> Key: BEAM-8335
> URL: https://issues.apache.org/jira/browse/BEAM-8335
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 60h 40m
> Remaining Estimate: 0h
>
> This issue tracks the work items to introduce streaming support to the
> Interactive Beam experience. This will allow users to:
> * Write and run a streaming job in IPython
> * Automatically cache records from unbounded sources
> * Add a replay experience that replays all cached records to simulate the
> original pipeline execution
> * Add controls to play/pause/stop/step individual elements from the cached
> records
> * Add ability to inspect/visualize unbounded PCollections
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
