[
https://issues.apache.org/jira/browse/BEAM-9339?focusedWorklogId=390218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390218
]
ASF GitHub Bot logged work on BEAM-9339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/20 20:09
Start Date: 20/Feb/20 20:09
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #10911: [BEAM-9339]
Declare capabilities for Go SDK.
URL: https://github.com/apache/beam/pull/10911#discussion_r382230929
##########
File path: sdks/go/pkg/beam/runners/universal/universal.go
##########
@@ -78,6 +78,20 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
return err
}
+const (
+ urnLegacyProgressReporting = "beam:protocol:progress_reporting:v0"
+ urnMultiCore =
"beam:protocol:multi_core_bundle_processing:v1"
+)
+
+func goCapabilities() []string {
+ capabilities := []string{
+ urnLegacyProgressReporting,
+ urnLegacyProgressReporting,
+ }
+ capabilities = append(capabilities, graphx.KnownStandardCoders()...)
+ return capabilities
+}
+
Review comment:
Fair enough.
Technically append always returns a new "slice" but the backing array for
the data may be reused. It's possible to have aliasing problems if done poorly,
but that's not a risk here.
It mostly comes down to the difference between the used length, and the
capacity of the slice. If there's enough capacity, it will simply mutate the
backing slice.
To avoid the aliasing, as a rule, one should avoid using an slice one didn't
allocate as the base for append.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 390218)
Time Spent: 2h (was: 1h 50m)
> Declare capabilities in SDK environments
> ----------------------------------------
>
> Key: BEAM-9339
> URL: https://issues.apache.org/jira/browse/BEAM-9339
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Robert Bradshaw
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
