[ 
https://issues.apache.org/jira/browse/BEAM-9339?focusedWorklogId=390291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390291
 ]

ASF GitHub Bot logged work on BEAM-9339:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Feb/20 22:16
            Start Date: 20/Feb/20 22:16
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on pull request #10911: [BEAM-9339] 
Declare capabilities for Go SDK.
URL: https://github.com/apache/beam/pull/10911#discussion_r382286309
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/graphx/coder.go
 ##########
 @@ -50,6 +50,22 @@ const (
        urnCoGBKList   = "beam:go:coder:cogbklist:v1" // CoGBK representation. 
Not a coder.
 )
 
+func KnownStandardCoders() []string {
 
 Review comment:
   Since this lives in the same package as the caller, we can make the function 
un-exported (lowercase k for knownStandardCoders() instead).
   
   It's reasonably to have this function live here, due to locality with the 
coder URNs
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 390291)
    Time Spent: 2h 20m  (was: 2h 10m)

> Declare capabilities in SDK environments
> ----------------------------------------
>
>                 Key: BEAM-9339
>                 URL: https://issues.apache.org/jira/browse/BEAM-9339
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-go, sdk-java-harness, sdk-py-harness
>            Reporter: Robert Bradshaw
>            Priority: Major
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to