[
https://issues.apache.org/jira/browse/BEAM-6374?focusedWorklogId=392929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392929
]
ASF GitHub Bot logged work on BEAM-6374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 21:09
Start Date: 25/Feb/20 21:09
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #10942: [BEAM-6374]
Emit PCollection metrics from GoSDK
URL: https://github.com/apache/beam/pull/10942#discussion_r384070704
##########
File path: sdks/go/pkg/beam/core/runtime/exec/datasource_test.go
##########
@@ -201,6 +201,16 @@ func TestDataSource_Iterators(t *testing.T) {
if got, want := iVals, expectedKeys; !equalList(got,
want) {
t.Errorf("DataSource => %#v, want %#v",
extractValues(got...), extractValues(want...))
}
+
+ // We're using small ints, so do some quick math to
validate.
+ sizeOfSmallInt := 1
Review comment:
Just checking, we use the size of a small int instead of an int64 because
the keys are encoded as small ints, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392929)
Time Spent: 40m (was: 0.5h)
> "elements added" for input and output collections is always empty
> -----------------------------------------------------------------
>
> Key: BEAM-6374
> URL: https://issues.apache.org/jira/browse/BEAM-6374
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow, sdk-go
> Reporter: Andrew Brampton
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The field for "Elements added" and "Estimated size" is always blank when
> running a Go binary on Dataflow. For example when running the work count
> example: https://pasteboard.co/HVf80BU.png
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
