[
https://issues.apache.org/jira/browse/BEAM-6374?focusedWorklogId=393015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393015
]
ASF GitHub Bot logged work on BEAM-6374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/20 22:36
Start Date: 25/Feb/20 22:36
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #10942: [BEAM-6374]
Emit PCollection metrics from GoSDK
URL: https://github.com/apache/beam/pull/10942#discussion_r384168998
##########
File path: sdks/go/pkg/beam/core/runtime/exec/datasource_test.go
##########
@@ -201,6 +201,16 @@ func TestDataSource_Iterators(t *testing.T) {
if got, want := iVals, expectedKeys; !equalList(got,
want) {
t.Errorf("DataSource => %#v, want %#v",
extractValues(got...), extractValues(want...))
}
+
+ // We're using small ints, so do some quick math to
validate.
+ sizeOfSmallInt := 1
Review comment:
You're right that my wording is ambiguous. I literally mean small ints as in
0-127 which are definitely encoded as a single byte with varint64 encoding.
If we use larger integers (as one of the PCollection tests do), the encoded
size is larger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 393015)
Time Spent: 50m (was: 40m)
> "elements added" for input and output collections is always empty
> -----------------------------------------------------------------
>
> Key: BEAM-6374
> URL: https://issues.apache.org/jira/browse/BEAM-6374
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow, sdk-go
> Reporter: Andrew Brampton
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The field for "Elements added" and "Estimated size" is always blank when
> running a Go binary on Dataflow. For example when running the work count
> example: https://pasteboard.co/HVf80BU.png
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
