[
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=393770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393770
]
ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/20 21:53
Start Date: 26/Feb/20 21:53
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10951: [BEAM-8575]
Modified the test to work for different runners.
URL: https://github.com/apache/beam/pull/10951#discussion_r384789304
##########
File path: sdks/python/apache_beam/transforms/combiners_test.py
##########
@@ -482,9 +485,13 @@ def
test_combining_with_accumulation_mode_and_fanout(self):
trigger=AfterWatermark(early=AfterAll(AfterCount(1))))
| beam.CombineGlobally(sum).without_defaults().with_fanout(2))
- # The frings for DISCARDING mode is [1, 2, 3, 4, 5, 0, 0].
- firings = [1, 3, 6, 10, 15, 15, 15]
- assert_that(result, equal_to(firings))
+ # Partition the result into early_firings and _.
+ # In ACCUMULATING mode, the early_frings is [1, 3, 6, 10], other
+ # firings are [15, 15, ...]. Different runners have different number
+ # of 15s.
+ early_firings, _ = result | beam.Partition(is_early_firing, 2)
+ exepected_early_firings = [1, 3, 6, 10]
+ assert_that(early_firings, equal_to(exepected_early_firings))
Review comment:
We still want to ensure there is at least one 15 firing. (If we're being
pedantic, a single on-time firing, plus a number of late firings) The second
argument to assert_that can be any predicate taking the set of actual elements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 393770)
Time Spent: 56h 50m (was: 56h 40m)
> Add more Python validates runner tests
> --------------------------------------
>
> Key: BEAM-8575
> URL: https://issues.apache.org/jira/browse/BEAM-8575
> Project: Beam
> Issue Type: Test
> Components: sdk-py-core, testing
> Reporter: wendy liu
> Assignee: wendy liu
> Priority: Major
> Time Spent: 56h 50m
> Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to
> improve test coverage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
