[ 
https://issues.apache.org/jira/browse/BEAM-8575?focusedWorklogId=393865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-393865
 ]

ASF GitHub Bot logged work on BEAM-8575:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Feb/20 00:18
            Start Date: 27/Feb/20 00:18
    Worklog Time Spent: 10m 
      Work Description: bumblebee-coming commented on pull request #10951: 
[BEAM-8575] Modified the test to work for different runners.
URL: https://github.com/apache/beam/pull/10951#discussion_r384845501
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/combiners_test.py
 ##########
 @@ -470,6 +470,9 @@ def test_combining_with_accumulation_mode_and_fanout(self):
       ts.add_elements([i])
     ts.advance_watermark_to_infinity()
 
+    def is_early_firing(element, num_partitions):
+      return 0 if element < 15 else 1
 
 Review comment:
   PaneInfo is not supported yet in Python.
   https://issues.apache.org/jira/browse/BEAM-3759
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 393865)
    Time Spent: 57h 10m  (was: 57h)

> Add more Python validates runner tests
> --------------------------------------
>
>                 Key: BEAM-8575
>                 URL: https://issues.apache.org/jira/browse/BEAM-8575
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-py-core, testing
>            Reporter: wendy liu
>            Assignee: wendy liu
>            Priority: Major
>          Time Spent: 57h 10m
>  Remaining Estimate: 0h
>
> This is the umbrella issue to track the work of adding more Python tests to 
> improve test coverage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to