[ https://issues.apache.org/jira/browse/BEAM-9305?focusedWorklogId=397744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-397744 ]
ASF GitHub Bot logged work on BEAM-9305: ---------------------------------------- Author: ASF GitHub Bot Created on: 04/Mar/20 18:25 Start Date: 04/Mar/20 18:25 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource URL: https://github.com/apache/beam/pull/11040#discussion_r387847682 ########## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ########## @@ -162,6 +163,15 @@ def test_iobase_source(self): query=self.query, use_standard_sql=True, project=self.project)) assert_that(result, equal_to(self.TABLE_DATA)) + @attr('IT') + def test_valueprovider_query_string(self): + query = StaticValueProvider(str, self.query) + with beam.Pipeline(argv=self.args) as p: + result = ( + p | 'read' >> beam.io._ReadFromBigQuery( + query=query, use_standard_sql=True, project=self.project)) + assert_that(result, equal_to(self.TABLE_DATA)) Review comment: could you use the value provider in another one of the tests in this file? Since each test in this file takes ~5min to run, I'd prefer to avoid adding a new test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 397744) Time Spent: 1h (was: 50m) > Support ValueProvider for BigQuerySource query string > ----------------------------------------------------- > > Key: BEAM-9305 > URL: https://issues.apache.org/jira/browse/BEAM-9305 > Project: Beam > Issue Type: New Feature > Components: io-py-gcp > Reporter: Elias Djurfeldt > Assignee: Elias Djurfeldt > Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Users should be able to use ValueProviders for the query string in > BigQuerySource. > Ref: > [https://stackoverflow.com/questions/60146887/expected-eta-to-avail-pipeline-i-o-and-runtime-parameters-in-apache-beam-gcp-dat/60170614?noredirect=1#comment106464448_60170614] -- This message was sent by Atlassian Jira (v8.3.4#803005)