[
https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=399911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399911
]
ASF GitHub Bot logged work on BEAM-8374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/20 20:05
Start Date: 08/Mar/20 20:05
Worklog Time Spent: 10m
Work Description: jfarr commented on issue #9758: [BEAM-8374] Enable
returning missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#issuecomment-596246326
Hi @lukecwik and @iemejia, I believe I have incorporated all of your review
feedback. I also made a few changes to the interface that I hope will improve
clarity:
- Instead of the confusingly named `fullSdkHttpMetadata()` and
`minimalSdkHttpMetadata()` methods, the `AwsCoders` class now has a method
`sdkHttpMetadata()` which creates a coder that by default does not include the
response headers, and if you want to include the headers there is also a method
`sdkHttpMetadata(boolean includeHeaders)`. I'm on the fence about getting rid
of the boolean parameter and just including a method like
`sdkHttpMetadataIncludingHeaders()` so let me know if you have a preference.
- I changed the names of the SnsIO methods to
`withFullPublishResultNoHeaders` and `withFullPublishResultIncludingHeaders`.
The default is still to encode only the messageId for backward compatibility. I
also added a method to specify your own coder for future extensibility.
I hope this PR is ready to merge now, please let me know if it needs any
additional changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 399911)
Time Spent: 5.5h (was: 5h 20m)
> PublishResult returned by SnsIO is missing sdkResponseMetadata and
> sdkHttpMetadata
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8374
> URL: https://issues.apache.org/jira/browse/BEAM-8374
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Minor
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Currently the PublishResultCoder in SnsIO only serializes the messageId field
> so the PublishResult returned by Beam returns null for
> getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible
> to check the HTTP status for errors, which is necessary since this is not
> handled in SnsIO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
