[
https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=400885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-400885
]
ASF GitHub Bot logged work on BEAM-8374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 17:35
Start Date: 10/Mar/20 17:35
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #9758: [BEAM-8374]
Enable returning missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#discussion_r390486390
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/sns/PublishResultCoders.java
##########
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.aws.sns;
+
+import com.amazonaws.ResponseMetadata;
+import com.amazonaws.http.SdkHttpMetadata;
+import com.amazonaws.services.sns.model.PublishResult;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.Serializable;
+import java.util.List;
+import java.util.Optional;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.CoderException;
+import org.apache.beam.sdk.coders.NullableCoder;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
+import org.apache.beam.sdk.io.aws.coders.AwsCoders;
+import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.collect.ImmutableList;
+
+/** Coders for SNS {@link PublishResult}. */
+public final class PublishResultCoders {
+
+ private static final Coder<String> MESSAGE_ID_CODER = StringUtf8Coder.of();
+ private static final Coder<ResponseMetadata> RESPONSE_METADATA_CODER =
+ AwsCoders.responseMetadata();
+
+ private PublishResultCoders() {}
+
+ /**
+ * Returns a new PublishResult coder which by default serializes only the
messageId.
+ *
+ * @return the PublishResult coder
+ */
+ public static Coder<PublishResult> defaultPublishResult() {
+ return new PublishResultCoder(null, null);
+ }
+
+ /**
+ * Returns a new PublishResult coder which serializes the
sdkResponseMetadata and sdkHttpMetadata,
+ * but does not include the HTTP response headers.
+ *
+ * @return the PublishResult coder
+ */
+ public static Coder<PublishResult> fullPublishResultNoHeaders() {
+ return new PublishResultCoder(RESPONSE_METADATA_CODER,
AwsCoders.sdkHttpMetadata());
+ }
+
+ /**
+ * Returns a new PublishResult coder which serializes the
sdkResponseMetadata and sdkHttpMetadata,
+ * including the HTTP response headers.
+ *
+ * @return the PublishResult coder
+ */
+ public static Coder<PublishResult> fullPublishResultIncludingHeaders() {
+ return new PublishResultCoder(RESPONSE_METADATA_CODER,
AwsCoders.sdkHttpMetadata(true));
+ }
+
+ private static class PublishResultCoder extends Coder<PublishResult>
implements Serializable {
+
+ private final Coder<ResponseMetadata> responseMetadataEncoder;
+ private final Coder<SdkHttpMetadata> sdkHttpMetadataCoder;
+
+ protected PublishResultCoder(
+ Coder<ResponseMetadata> responseMetadataEncoder,
+ Coder<SdkHttpMetadata> sdkHttpMetadataCoder) {
+ this.responseMetadataEncoder =
+
Optional.ofNullable(responseMetadataEncoder).map(NullableCoder::of).orElse(null);
Review comment:
Why add this complexity here, just pass in a
NullableCoder.of(RESPONSE_METADATA_CODER) and perform assignment here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 400885)
Time Spent: 6h 50m (was: 6h 40m)
> PublishResult returned by SnsIO is missing sdkResponseMetadata and
> sdkHttpMetadata
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8374
> URL: https://issues.apache.org/jira/browse/BEAM-8374
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Minor
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> Currently the PublishResultCoder in SnsIO only serializes the messageId field
> so the PublishResult returned by Beam returns null for
> getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible
> to check the HTTP status for errors, which is necessary since this is not
> handled in SnsIO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
