[
https://issues.apache.org/jira/browse/BEAM-9213?focusedWorklogId=403005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403005
]
ASF GitHub Bot logged work on BEAM-9213:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/20 17:27
Start Date: 13/Mar/20 17:27
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #10708: [BEAM-9213]
throw error when flink_submit_uber_jar and not flink_master
URL: https://github.com/apache/beam/pull/10708#discussion_r392370237
##########
File path: sdks/python/apache_beam/runners/portability/flink_runner.py
##########
@@ -51,8 +51,11 @@ def default_job_server(self, options):
flink_master = self.add_http_scheme(
flink_options.flink_master)
flink_options.flink_master = flink_master
- if (flink_options.flink_submit_uber_jar
- and flink_master not in MAGIC_HOST_NAMES):
+ if flink_options.flink_submit_uber_jar:
+ if flink_master in MAGIC_HOST_NAMES:
+ raise ValueError(
+ 'Cannot use flink_submit_uber_jar with flink_master %s'
+ % flink_master)
Review comment:
Circling back on this now that BEAM-9225 is resolved.
> (1) If no options are provided, a local flink cluster is started up and is
used,
> (2) If a master is specified, we submit it to that job in the least
intrusive way possible (IMHO, the so-called uberjar method, though I'm curious
about BEAM-9225).
This makes sense to me. I'm leaning toward removing `flink_submit_uber_jar`
and replacing the condition with `flink_master`.
> How about a --force-mode parameter which would enforce a specific mode,
e.g. --force-mode uberjar to user the uber jar mode.
I prefer removing parameters where possible. Ideally we can come up with a
solution here that works without the user having to know all about the
different implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403005)
Time Spent: 2h 20m (was: 2h 10m)
> FlinkRunner ignores --flink_submit_uber_jar when master unset
> -------------------------------------------------------------
>
> Key: BEAM-9213
> URL: https://issues.apache.org/jira/browse/BEAM-9213
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Minor
> Labels: portability-flink
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Instead, an error should be thrown to let the user know that
> flink_submit_uber_jar is incompatible with auto/local master.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
