[ 
https://issues.apache.org/jira/browse/BEAM-9454?focusedWorklogId=403162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403162
 ]

ASF GitHub Bot logged work on BEAM-9454:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Mar/20 20:40
            Start Date: 13/Mar/20 20:40
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on pull request #11060: [BEAM-9454] 
Create Deduplication transform based on user timer/state
URL: https://github.com/apache/beam/pull/11060#discussion_r392461155
 
 

 ##########
 File path: sdks/python/apache_beam/runners/sdf_utils.py
 ##########
 @@ -244,3 +251,63 @@ def get_estimator_state(self):
         return None
 
     return _NoOpWatermarkEstimator()
+
+
+class DeduplictaionWithinDuration(ptransform.PTransform):
 
 Review comment:
   Thanks Udi! Similar to `watermark_estimators.py`, I'm thinking about 
providing a collection of transforms for deduplicating purpose. Any reason that 
we don't put a group of similar transforms into one module? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 403162)
    Time Spent: 2h 10m  (was: 2h)

> Add Deduplication transform for SDF
> -----------------------------------
>
>                 Key: BEAM-9454
>                 URL: https://issues.apache.org/jira/browse/BEAM-9454
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Boyuan Zhang
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> When SDF is used as a source-like operation, it's necessary to provide a 
> default Deduplication transform for the SDF user to deduplicate values by 
> certain unique id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to