[
https://issues.apache.org/jira/browse/BEAM-9454?focusedWorklogId=404980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404980
]
ASF GitHub Bot logged work on BEAM-9454:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/20 21:25
Start Date: 17/Mar/20 21:25
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11060: [BEAM-9454]
Create Deduplication transform based on user timer/state
URL: https://github.com/apache/beam/pull/11060#discussion_r393968339
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner_test.py
##########
@@ -448,6 +449,42 @@ def is_buffered_correctly(actual):
assert_that(actual, is_buffered_correctly)
+ def test_deduplication_transform_with_processing_time(self):
Review comment:
fn_api_runner_test primarily for testing primitives. I would put this in
apache_beam.transforms.deduplicate_test (or util_test, if that's where we plan
to move it).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404980)
Time Spent: 2.5h (was: 2h 20m)
> Add Deduplication transform for SDF
> -----------------------------------
>
> Key: BEAM-9454
> URL: https://issues.apache.org/jira/browse/BEAM-9454
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core, sdk-py-core
> Reporter: Boyuan Zhang
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> When SDF is used as a source-like operation, it's necessary to provide a
> default Deduplication transform for the SDF user to deduplicate values by
> certain unique id.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
