[
https://issues.apache.org/jira/browse/BEAM-9383?focusedWorklogId=403281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403281
]
ASF GitHub Bot logged work on BEAM-9383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/20 23:49
Start Date: 13/Mar/20 23:49
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #11039:
[BEAM-9383] Staging Dataflow artifacts from environment
URL: https://github.com/apache/beam/pull/11039#discussion_r392530711
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -563,19 +562,31 @@ def _gcs_file_copy(self, from_path, to_path):
with open(from_path, 'rb') as f:
self.stage_file(to_folder, to_name, f, total_size=total_size)
- def _stage_resources(self, options):
+ def _stage_resources(self, pipeline, options):
google_cloud_options = options.view_as(GoogleCloudOptions)
if google_cloud_options.staging_location is None:
raise RuntimeError('The --staging_location option must be specified.')
if google_cloud_options.temp_location is None:
raise RuntimeError('The --temp_location option must be specified.')
+ resources = []
+ for _, env in pipeline.components.environments.items():
+ for dep in env.dependencies:
+ if dep.type_urn != common_urns.artifact_types.FILE.urn:
+ raise RuntimeError('unsupported artifact type %s' % dep.type_urn)
+ if dep.role_urn != common_urns.artifact_roles.STAGING_TO.urn:
+ raise RuntimeError('unsupported role type %s' % dep.role_urn)
+ type_payload = beam_runner_api_pb2.ArtifactFilePayload.FromString(
+ dep.type_payload)
+ role_payload = \
Review comment:
Nit: Pls use ( instead of \ for formatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403281)
Time Spent: 1h (was: 50m)
> Staging Dataflow artifacts from environment
> -------------------------------------------
>
> Key: BEAM-9383
> URL: https://issues.apache.org/jira/browse/BEAM-9383
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Staging Dataflow artifacts from environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
