[
https://issues.apache.org/jira/browse/BEAM-9383?focusedWorklogId=405867&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405867
]
ASF GitHub Bot logged work on BEAM-9383:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 00:31
Start Date: 19/Mar/20 00:31
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #11039: [BEAM-9383]
Staging Dataflow artifacts from environment
URL: https://github.com/apache/beam/pull/11039#discussion_r394721868
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -752,6 +759,27 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
}
}
+ private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
Review comment:
It's private method so we can't directly test it. Existing test (such as
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java#L758)
should cover this method too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 405867)
Time Spent: 1.5h (was: 1h 20m)
> Staging Dataflow artifacts from environment
> -------------------------------------------
>
> Key: BEAM-9383
> URL: https://issues.apache.org/jira/browse/BEAM-9383
> Project: Beam
> Issue Type: Sub-task
> Components: java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Staging Dataflow artifacts from environment
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
